Parse NCBI create date for biosamples #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcezard
commented
Jul 3, 2025
Comment on lines
125
to
131
| except HTTPError as e: | ||
| if e.response.status_code == 500: | ||
| self.add_error(json_path, f'{accession_type} {ena_accession} could not be resolve on ENA because the service is unavailable. try again later.') | ||
| else: | ||
| self.add_error(json_path, f'{accession_type} {ena_accession} does not exist in ENA or is private') | ||
| except Exception as e: | ||
| self.add_error(json_path, f'Unexpected error occurred when checking {accession_type} {ena_accession}') |
Member
Author
There was a problem hiding this comment.
This is to differentiate between private samples and failed API calls in the report
tcezard
commented
Jul 3, 2025
| {'description': 'Existing sample SAME00004 does not have a valid geographic location', 'property': '/sample/3/bioSampleAccession'}]) | ||
|
|
||
| @pytest.mark.skip(reason='Contact BioSample API') | ||
| def test_check_existing_real_biosamples(self): |
Member
Author
There was a problem hiding this comment.
Useful to test a specific Biosample.
apriltuesday
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.