EVA-3825: Add text reports for validation #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitin-ebi
approved these changes
Jun 11, 2025
tcezard
approved these changes
Jun 12, 2025
Member
tcezard
left a comment
tcezard
left a comment
There was a problem hiding this comment.
I think it looks great and has a nice use of Unicode.
The duplication of the report is a bit of a bother although it means we can deal with the specifics of each (text vs html) separately.
Originally I had started looking into generating reports in markdown as they can be converted in HTML/PDF but I'm not sure we would have gotten the same results.
Contributor
Author
|
@tcezard Agree that the duplication isn't ideal, I also looked into converting one report type to another but it would have been difficult to keep each report legible. I tried to keep the two sets of templates as similar as possible, so that it would be a bit easier to change both in parallel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.