Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is obsolete related issues #692

Merged
merged 12 commits into from
Jul 26, 2024
Merged

Is obsolete related issues #692

merged 12 commits into from
Jul 26, 2024

Conversation

henrietteharmse
Copy link
Collaborator

No description provided.

@henrietteharmse
Copy link
Collaborator Author

henrietteharmse commented Jul 26, 2024

I think it will be a good idea to do the testcase updates in a different commit in future.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any banner related changes regarding this PR?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should remove this whitespace/newline

Copy link
Collaborator

@haideriqbal haideriqbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have left some comments regarding banner changes... otherwise all good!

@henrietteharmse
Copy link
Collaborator Author

Yes, there were banner changes to fix #689.

@henrietteharmse henrietteharmse merged commit 2971e17 into dev Jul 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants