Repository navigation
Chore: ComponentsV2 for Coop Messages - #400
Open
DavidArthurCole wants to merge 5 commits into
Open
DavidArthurCole wants to merge 5 commits into
DavidArthurCole wants to merge 5 commits into
Conversation
Harsharoni
added
chore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously sent a static count of 4/5 messages, which was overkill for a lot of coops. The first part of is that we now calculate the "worst case size" for a coop, and send that many messages, to avoid un-necessary calls.
Second part was changing from messages to ComponentV2, so that we have a higher character limit. In the worst case scenario, with a 50 player coop, and all of the worst text, it goes into 4 components now. Should be much faster message sending.