Enable land only ilamb and global time-series (for J case spin up) #765

chengzhuzhang · 2025-12-07T21:41:37Z

Summary

Objectives:
Based on a thread with @xuezhengllnl , for the alternating B/J cases spin-up runs from v3.HR runs,
zppy cfg file cannot run ilamb for the J-case segment of the v3HR spinup run because J-case configuration has no eam hist outputs. We will need to check the time evolution of the land condition for both J-case segments and B-case segments. Starting 0106-0165 for 60years J case (no atm), 0166-0175 10 years Bcase (fully coupled with atm). And recycle.

Note: J-case means interactive ocean, seaice, land model with atmospheric forcing (no EAM model). B-case means fully coupled model configuration. The v3HR spin-up simulation includes both configurations.

Enable land only ilamb when no atm data present.
Enable global time-series when no atm data present.
Fix a bug in climo task for enabling generating mosart climatology using ncclimo.
For global time-series tasks: copy ocean results to case_dir and clean up results dir

Select one: This pull request is...

a bug fix: increment the patch version
a small improvement: increment the minor version
a new feature: increment the minor version
an incompatible (non-backwards compatible) API change: increment the major version

Small Change

To merge, I will use "Squash and merge". That is, this change should be a single commit.
- Will use merge commit because work was done in well-isolated commits.
Logic: I have visually inspected the entire pull request myself.
Pre-commit checks: All the pre-commits checks have passed.

chengzhuzhang · 2025-12-11T00:20:31Z

@forsyth2 If time allows, could you make a code review to see if there are any issues i should pay attention to? This PR does 4 things:

Enable land only ilamb when no atm data present.
Enable global time-series when no atm data present.
Fix a bug in climo task for enabling generating mosart climatology using ncclimo.
For global time-series tasks: copy ocean results to case_dir and clean up results dir

forsyth2

@chengzhuzhang I think it would be a good idea to run the integration tests to make sure nothing breaks there, but my visual inspection appears fine:

✅ Enable land only ilamb when no atm data present.
✅ Enable global time-series when no atm data present.
✅ Fix a bug in climo task for enabling generating mosart climatology using ncclimo.
✅ For global time-series tasks: copy ocean results to case_dir and clean up results dir

I added some explanatory comments on the PR just for my understanding. The code may benefit from increased commenting, but this is non-essential.

forsyth2 · 2025-12-15T19:40:30Z

zppy/templates/ilamb.bash

 # Create output directory
 # Create local links to input cmip time-series files
 lnd_ts_for_ilamb={{ output }}/post/lnd/{{ ts_land_grid }}/cmip_ts/monthly/
+{% if not land_only %}


✅ Part 1 of fix for "Enable land only ilamb when no atm data present."

forsyth2 · 2025-12-15T19:40:45Z

zppy/templates/ilamb.bash

    echo 'ERROR (1)' > {{ prefix }}.status
    exit 1
  fi
+{% if not land_only %}


✅ Part 2 of fix for "Enable land only ilamb when no atm data present."

forsyth2 · 2025-12-15T19:42:14Z

zppy/global_time_series.py

+        # Only require ATM if we have non-ocean plots
+        if has_atm_plots:
+            c["use_atm"] = True


✅ Fix for "Enable global time-series when no atm data present."

forsyth2 · 2025-12-15T19:42:53Z

zppy/utils.py

        prc_typ = tmp
    elif tmp in ("mosart",):
        component = "rof"
+        prc_typ = tmp


✅ Fix for "Fix a bug in climo task for enabling generating mosart climatology using ncclimo."

forsyth2 · 2025-12-15T19:43:42Z