-
Notifications
You must be signed in to change notification settings - Fork 15
Allow tests to use different mpas_analysis environment
#763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
forsyth2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chengzhuzhang I think this should be fine to merge.
A couple notes:
- The bundle cfgs weren't updated because they don't have a
mpas_analysistask set up. - I did update the legacy cfgs, which we normally think of as "frozen", but the change is the value of
environment_commands, not the parameters themselves. So, it's really no different than, for example, running the lateste3sm_diagsdev environment on a legacy cfg.
|
okay, I thought specifying |
mpas_analysis environment
Yes, sorry, I tried to clear that up in the PR description. This is exclusively for auto-generating the test cfgs.
Good idea; I've updated it to "Allow tests to use different |
|
These are sort-of meta-environment commands -- i.e., |
|
That's also why nothing changes in |
|
I'm going to hold off on merging this until we get a passing test of #760. Based on #760 (comment), it makes sense to add a conditional change to the |
|
Now that #760 has merged, I'm also going to merge this testing fix. |
Summary
Objectives:
environment_commandsformpas_analysisin testing. (Note this was always possible as a user: just setenvironment_commandsin the cfg).Issue resolution:
Select one: This pull request is...
Small Change