Skip to content

Conversation

@forsyth2
Copy link
Collaborator

@forsyth2 forsyth2 commented Dec 1, 2025

Summary

Objectives:

  • Add legacy cfgs for zppy v3.1.0

Select one: This pull request is...

  • a bug fix: increment the patch version
  • a small improvement: increment the minor version
  • a new feature: increment the minor version
  • an incompatible (non-backwards compatible) API change: increment the major version

Small Change

  • To merge, I will use "Squash and merge". That is, this change should be a single commit.
  • Logic: I have visually inspected the entire pull request myself.
  • Pre-commit checks: All the pre-commits checks have passed.

@forsyth2 forsyth2 self-assigned this Dec 1, 2025
@forsyth2 forsyth2 added the Testing Files in `tests` modified label Dec 1, 2025
Copy link
Collaborator Author

@forsyth2 forsyth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chengzhuzhang To continue legacy testing, I've added cfgs that are meant to be "frozen" in time at zppy v3.1.0. (Right now, they're identical copies of the main set of cfgs).

I think it would be over-testing to continue testing the v3.0.0 legacy cfgs as well, so my plan is to keep the cfgs but remove them from the default list (i.e., commenting them out in tests/integration/utils.py). That way, they can still be tested if questions of backwards compatibility arise or during more rigorous testing periods, like E3SM Unified testing.

Let me know if you have any questions/comments, otherwise I think this should be fine to merge.

@chengzhuzhang
Copy link
Collaborator

You plan sounds good to me. Thanks!

@forsyth2
Copy link
Collaborator Author

forsyth2 commented Dec 9, 2025

Sounds good, thanks! I'll go ahead and merge then.

Comment on lines +277 to +279
"weekly_legacy_3.1.0_bundles",
"weekly_legacy_3.1.0_comprehensive_v2",
"weekly_legacy_3.1.0_comprehensive_v3",
Copy link
Collaborator Author

@forsyth2 forsyth2 Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (the second commit, 4465ca4) is a minor update just for completeness. It's only relevant when TEST_SPECIFICS["cfgs_to_run"] == [] and I usually only run a subset of cfgs.

@forsyth2 forsyth2 merged commit ac7dca2 into main Dec 9, 2025
7 checks passed
@forsyth2 forsyth2 deleted the add-legacy-cfgs branch December 9, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing Files in `tests` modified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants