Update from Consortium Main Oct 8, 2022 #125f03a #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CE-Consortium#399) In subroutine icepack_therm_shared::icepack_init_trcr, 'Tair' is documented as having units 'C' (degrees Celsius), but this is incorrect, this variable is in Kelvins. This can be seen a few lines below where we compute Tsfc: Tsfc = min(Tsmelt, Tair - Tffresh) ! deg C where 'Tffresh' is the freezing point of fresh ice in Kelvins, 273.15, as defined in icepack_parameters. Fix the units in the declaration comment. Reported-by: Frederic Dupont <frederic.dupont@canada.ca>
* Implement several dEdd fixes - update g/w0/tau calculation, get rid of use of puny - add missing g/w0/tau calculation after "aerosol in snow" calculation - fix bug in computation of modal_aero taer/waer/gaer, changed divide to multiple of rnilyr/rnslyr - refactor divides of rnilyr/rnslyr to multiplies of real(nilyr/nslyr) Generally changes answers for tr_aero * Update test suites, add modal test * Add set_nml.modal * Update icepack_shortwave.F90 with minor changes to implementation consistent with E3SM Icepack snicar upgrades This change is bit-for-bit for the full test suite on cheyenne.
* close nu_diag * close more files * close restart file after bgc has been read
…o upd01a Oct 8, 2022
eclare108213
approved these changes
Oct 10, 2022
apcraig
merged commit 881db9a
into
E3SM-Project:cice-consortium/E3SM-icepack-initial-integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Short (1 sentence) summary of your PR:
Update from Consortium Main Oct 8, 2022 #125f03a
Developer(s):
apcraig
Suggest PR reviewers from list in the column to the right.
Please copy the PR test results link or provide a summary of testing completed below.
bit-for-bit on cheyenne with 3 compilers full Icepack test suite
How much do the PR code changes differ from the unmodified code?
Does this PR create or have dependencies on CICE or any other models?
Does this PR add any new test cases?
Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
Please provide any additional information or relevant details below:
Update to close unit numbers as workaround for Mac OS bug
New modal Icepack tests
Remove pondcesm test
icepack_shortwave changes NOT updated due to divergence, but implementations are consistent