Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ocean divergenceAtSurface to highFrequencyStats #6892

Conversation

dylanschlichting
Copy link
Contributor

This commit mirrors #6566, but adds divergence at the surface. This is useful for MPAS-O meshes capable of permitting or resolving submesoscale processes. Divergence is a key diagnostic of submesoscale flows, in particular identifying regions of frontogenesis and frontolysis. The variable is added to the default output for highFrequencyStats, but is an optional 2D field.

Currently, this is used for our high-resolution Gulf of Mexico simulations and will be useful for future high-resolution campaigns.

Copy link
Contributor

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving by inspection. This looks good to me.

Copy link
Contributor

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me too. @dylanschlichting please document the machines and compilers where you tested this.

@dylanschlichting
Copy link
Contributor Author

Passes the following test on Chicoma gpu_gnu. Can confirm that divergenceAtSurface is added to streams.ocean.

cd /usr/projects/climate/dschlichting/repos/E3SM/add-surface-divergence/cime/scripts

./create_test SMS_Ld3.T62_oQU240.GMPAS-NYF.chicoma-gpu_gnu -p t25_coastal_ocean_g --walltime 00:30:00
create_test will do up to 1 tasks simultaneously
create_test will use up to 160 cores simultaneously
Creating test directory /lustre/scratch5/dschlichting/E3SM/scratch/chicoma-gpu/SMS_Ld3.T62_oQU240.GMPAS-NYF.chicoma-gpu_gnu.20250114_071150_j22dya
RUNNING TESTS:
  SMS_Ld3.T62_oQU240.GMPAS-NYF.chicoma-gpu_gnu
Starting CREATE_NEWCASE for test SMS_Ld3.T62_oQU240.GMPAS-NYF.chicoma-gpu_gnu with 1 procs
Finished CREATE_NEWCASE for test SMS_Ld3.T62_oQU240.GMPAS-NYF.chicoma-gpu_gnu in 1.988298 seconds (PASS)
Starting XML for test SMS_Ld3.T62_oQU240.GMPAS-NYF.chicoma-gpu_gnu with 1 procs
Finished XML for test SMS_Ld3.T62_oQU240.GMPAS-NYF.chicoma-gpu_gnu in 0.638624 seconds (PASS)
Starting SETUP for test SMS_Ld3.T62_oQU240.GMPAS-NYF.chicoma-gpu_gnu with 1 procs
Finished SETUP for test SMS_Ld3.T62_oQU240.GMPAS-NYF.chicoma-gpu_gnu in 10.654403 seconds (PASS)
Starting SHAREDLIB_BUILD for test SMS_Ld3.T62_oQU240.GMPAS-NYF.chicoma-gpu_gnu with 1 procs
Finished SHAREDLIB_BUILD for test SMS_Ld3.T62_oQU240.GMPAS-NYF.chicoma-gpu_gnu in 136.573637 seconds (PASS)
Starting MODEL_BUILD for test SMS_Ld3.T62_oQU240.GMPAS-NYF.chicoma-gpu_gnu with 7 procs
Finished MODEL_BUILD for test SMS_Ld3.T62_oQU240.GMPAS-NYF.chicoma-gpu_gnu in 361.701535 seconds (PASS)
Starting RUN for test SMS_Ld3.T62_oQU240.GMPAS-NYF.chicoma-gpu_gnu with 1 proc on interactive node and 64 procs on compute nodes
Finished RUN for test SMS_Ld3.T62_oQU240.GMPAS-NYF.chicoma-gpu_gnu in 5.039733 seconds (PEND). [COMPLETED 1 of 1]
Waiting for tests to finish
PEND SMS_Ld3.T62_oQU240.GMPAS-NYF.chicoma-gpu_gnu (phase RUN has not yet completed)

cd /lustre/scratch5/dschlichting/E3SM/scratch/chicoma-gpu/SMS_Ld3.T62_oQU240.GMPAS-NYF.chicoma-gpu_gnu.20250114_071150_j22dya

./case.submit

#Confirm divergenceAtSurface is in streams.ocean
vi run/streams.ocean
319     <var name="divergenceAtSurface"/> 

@jonbob jonbob added the BFB PR leaves answers BFB label Jan 21, 2025
jonbob added a commit that referenced this pull request Jan 21, 2025
…(PR #6892)

Add ocean divergenceAtSurface to highFrequencyStats

This commit mirrors PR #6566, but adds divergence at the surface. This
is useful for MPAS-O meshes capable of permitting or resolving
submesoscale processes. Divergence is a key diagnostic of submesoscale
flows, in particular identifying regions of frontogenesis and
frontolysis. The variable is added to the default output for
highFrequencyStats, but is an optional 2D field.

[BFB]
@jonbob
Copy link
Contributor

jonbob commented Jan 21, 2025

Passes:

  • SMS_D_Ld1.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.chrysalis_intel.allactive-wcprod

merged to next

@jonbob jonbob merged commit 5f4c208 into E3SM-Project:master Jan 22, 2025
4 checks passed
@jonbob
Copy link
Contributor

jonbob commented Jan 22, 2025

merged to master

@dylanschlichting dylanschlichting deleted the dylanschlichting/ocn/add-surface-divergence branch January 22, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB mpas-ocean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants