Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs in inactive top cells feature #5245

Closed
cbegeman opened this issue Oct 20, 2022 · 0 comments · Fixed by #5246
Closed

Bugs in inactive top cells feature #5245

cbegeman opened this issue Oct 20, 2022 · 0 comments · Fixed by #5246
Assignees
@xylar @cbegeman
Labels
bug mpas-ocean

Comments

@cbegeman
Copy link
Contributor

I uncovered two bugs that affect the inactive top cells feature (i.e., when minLevelCell > 1), one in ocn_diagnostic_solve_ssh and the other affects the sea ice salinity flux in ocn_surface_bulk_forcing. In both instances, the vertical index was hard-coded as 1 and should instead be the minLevelCell or minLevelEdge*.

The test case that uncovered these bugs and related discussion is MPAS-Dev/compass#164.
@xylar xylar mentioned this issue Oct 20, 2022
Merged
jonbob added a commit that referenced this issue Nov 7, 2022
@jonbob
Merge branch 'cbegeman/ocn/bugfix-inactive-top-cells' into next (PR #…
a1e57b4 
…5246)

This PR fixes 2 bugs that affect the inactive top cells feature (i.e.,
when minLevelCell > 1). One in ocn_diagnostic_solve_ssh and the other
affects the sea ice salinity flux in ocn_surface_bulk_forcing. No
changes in the solution should occur when there are no inactive top
cells.

This PR also includes a cleanup of Redi. The original clunky workaround
was designed to avoid non-bfb changes in BGC tracers, and this revision
introduces those potentially non-bfb changes as @maltrud determined that
they are insignificant.

Fixes #5245
[BFB]
@jonbob jonbob closed this as completed in 7591f33 Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xylar xylar

@cbegeman cbegeman

Labels
bug mpas-ocean
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfixes for ocean inactive top cells feature cbegeman/E3SM
2 participants
@xylar @cbegeman