i#7604 user data: Add drmgr exit event #7610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a drmgr exit event which replaces the base DR event and provides priorities and user_data parameters. The drmgr_exit() function could now become a nop (because drmgr must delay its clean up until *after* all client exit events), but to avoid crashes in legacy clients who themselves don't use drmgr but libraries they use do use drmgr, we have drmgr cleanup performed only after both drmgr_exit() reaches a 0 counter and the drmgr exit event has been called. drx_register_time_scaling() is now documented to require the user to use drmgr (otherwise the drmgr exit could be before the client's exit). Updates all our samples and tests to use the drmgr event. Adds a note to the minor compatibility change list as this will break user's builds, but has no binary compatibility consequence. Issue: #7604
Contributor
Author
|
This one should be merged by itself and so coordinated vs #7591 |
abhinav92003
approved these changes
Aug 28, 2025
…t unreg in release notes; update comments
This was referenced Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a drmgr exit event which replaces the base DR event and provides priorities and user_data parameters.
The drmgr_exit() function could now become a nop (because drmgr must delay its clean up until after all client exit events), but to avoid crashes in legacy clients who themselves don't use drmgr but libraries they use do use drmgr, we have drmgr cleanup performed only after both drmgr_exit() reaches a 0 counter and the drmgr exit event has been called.
The drx_time_scale test is left not using drmgr as a test of this (it crashes without drmgr exit being delayed for both conditions).
drx_register_time_scaling() is now documented to require the user to use drmgr (otherwise the drmgr exit could be before the client's exit).
Uses the new user_data to clean up the global variable from the drx_timeout_scale test.
Updates all our samples and tests to use the drmgr event.
Adds a note to the minor compatibility change list as this will break user's builds, but has no binary compatibility consequence.
Issue: #7604