move python test out of core #16760
Open
move python test out of core #16760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinzart90
commented
Dec 1, 2025
This reverts commit 0383df8.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| public void PythonEnginePackageDependencyIsCollectedAndSerialized() | ||
| { | ||
| // Load JSON file graph | ||
| string path = Path.Combine(TestDirectory, @"core\packageDependencyTests\PythonDependency.dyn"); |
| Assert.IsEmpty(json[WorkspaceReadConverter.NodeLibraryDependenciesPropString]); | ||
| } | ||
|
|
||
| string packageDirectory = Path.Combine(TestDirectory, @"core\packageDependencyTests\PythonEnginePackage"); |
pinzart90
changed the title
Member
|
@pinzart90 I don't understand from your description if you found what was causing the test failure or not? |
mjkkirschner
approved these changes
Dec 2, 2025
Member
|
@pinzart90 there is a test failure: maybe these tests are interacting, does this test fixture pass locally for you now that you moved the test here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Issue:
Test
Dynamo.Tests.PackageDependencyTests.PythonEnginePackageDependencyIsCollectedAndSerializedis failing for DynamoCoreService (DaaS)What changed:
Moved the
PythonEnginePackageDependencyIsCollectedAndSerializedtest from DynamoCoreTests to DynamoPythonTests.DynamoCoreService does not use python (yet), so testing python for DaaS is not critical.
Temporary fix on the linux job side https://git.autodesk.com/Dynamo/DynamoSelfServe/commit/1cfa6cc385d19a7a513f5132cce4307580f4f55b
Declarations
Check these if you believe they are true
Release Notes
Moved python test from DynamoCoreTests to DynamoPythonTests
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of