DYN-9676 Optimize IsAssignableFromDictionary #16593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 98f38f6)
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the IsAssignableFromDictionary method to improve VM performance by replacing LINQ operations with direct loops and adding early return optimizations. The changes are part of a performance improvement initiative that reduces method execution time by 75% for graphs with significant data.
Key changes:
- Replaces LINQ-based interface checking with direct array iteration
- Adds fast-path checks for common dictionary types
- Includes a minor optimization for StackValue casting
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9676
Contributor
Contributor
zeusongit
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://jira.autodesk.com/browse/DYN-9676
This PR optimizes the IsAssignableFromDictionary logic as it is on the hot path for execution. The call can be invoked repeatedly in Graph execution. This PR removes the use of LINQ to improve the throughput and memory usage.
For a graph with significant data this PR reduces the call time for this method by 75%
master:
PR:
Declarations
Check these if you believe they are true
Release Notes
VM Performance Improvements
Reviewers
FYIs