DYN-9533: Update protogeometry.config, update ASM file mask for ASM 232 #16569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes geometry test failures by updating the ProtoGeometry configuration to point to the correct libg subfolder and updating the ASM file mask pattern to accommodate One ASM naming changes.
- Updated ProtoGeometry.config to reference the correct libg version (232_0_0 instead of 231_0_0)
- Modified ASM file mask to remove suffix requirement due to One ASM binary naming changes
- Removed failure category from a geometry test that should now pass
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| extern/ProtoGeometry/ProtoGeometry.config | Updates GeometryFactoryFileName path from libg_231_0_0 to libg_232_0_0 |
| src/Tools/DynamoShapeManager/Utilities.cs | Removes 'A' suffix from ASM file mask pattern to match One ASM naming |
| test/Libraries/WorkflowTests/GeometryDefectTests.cs | Removes [Category("Failure")] attribute from geometry test |
aparajit-pratap
changed the title
aparajit-pratap
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9533
QilongTang
reviewed
Oct 3, 2025
| } | ||
|
|
||
| [Test] | ||
| [Category("Failure")] |
Contributor
There was a problem hiding this comment.
Assuming this is expected diff after ASM 232 update, do we need a task to fix this later?
QilongTang
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
I believe geometry tests are failing due to the
protogeometry.configfile pointing to the wrong libg subfolder corresponding to the ASM version that's on the CI machines. This could be one of the issues why no new daily builds for 4.0 are being published to dynamobuilds.com.Additionally due to the One ASM changes, there is no
AorIsuffix to ASM binary naming anymore, due to which the ASM file mask we're using to search for ASM installations needs to be updated.Declarations
Check these if you believe they are true
Release Notes
N/A
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of