Skip to content

Conversation

@BogdanZavu
Copy link
Contributor

@BogdanZavu BogdanZavu commented Jul 9, 2025

Purpose

Reuse NodeAutoCompleteBar window.
Handle multiple workspaces scenarios.

Declarations

Check these if you believe they are true

  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB
  • This PR introduces new feature code involve network connecting and is tested with no-network mode.

Release Notes

Reuse node autocomplete window as much as possible in order to improve memory consumption and UI performance.

Reviewers

@DynamoDS/synapse

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9104

@chubakueno
Copy link
Contributor

Bear in mind that I added a couple of events here for listening for node repositioning and so on #16341 , will have to be considered on merge depending on merge order.

@BogdanZavu
Copy link
Contributor Author

Bear in mind that I added a couple of events here for listening for node repositioning and so on #16341 , will have to be considered on merge depending on merge order.

I think it makes more sense to merge your pr first.

@johnpierson
Copy link
Member

sweet. @chubakueno PR is merged so this one could use a rebase

@johnpierson
Copy link
Member

Would be good to get this rebased from master now.

Copy link
Member

@johnpierson johnpierson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working great. tested between custom nodes and home workspaces

@BogdanZavu BogdanZavu merged commit 1d99407 into DynamoDS:master Jul 11, 2025
26 of 28 checks passed
@BogdanZavu BogdanZavu deleted the DYN-9104 branch July 11, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants