-
Notifications
You must be signed in to change notification settings - Fork 667
DYN-9104 : reuse node autocomplete bar plus other fixes #16359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9104
|
Bear in mind that I added a couple of events here for listening for node repositioning and so on #16341 , will have to be considered on merge depending on merge order. |
I think it makes more sense to merge your pr first. |
|
sweet. @chubakueno PR is merged so this one could use a rebase |
|
Would be good to get this rebased from master now. |
johnpierson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
working great. tested between custom nodes and home workspaces
Purpose
Reuse NodeAutoCompleteBar window.
Handle multiple workspaces scenarios.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reuse node autocomplete window as much as possible in order to improve memory consumption and UI performance.
Reviewers
@DynamoDS/synapse