Skip to content

Conversation

@zeusongit
Copy link
Contributor

Purpose

Based on #15832

It was identified that when working with connectors, the temporary connectors (dotted wires) were not properly disposed, the PR disposes them properly when the wire connection is made.

Also, added a few more unsubscription related to nodes.

Results:

Tested twice with VS Memory Profiler.
Action: Opened Mars graph and closed twice in the same session.

After (Left) : Before (Right)
Screenshot 2025-05-07 at 7 17 09 PM

Screenshot 2025-05-07 at 7 20 07 PM

NodeViewModel (Inclusive of all child elements size):
Before: ~150 MB
After: ~10MB
~93% drop
(The drop was due to node leak fix, as no interaction was done with wires when testing)

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • Fix temporary connector and Node memory leak

Reviewers

@DynamoDS/eidos

@zeusongit zeusongit requested review from a team and mjkkirschner May 8, 2025 22:11
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8308

Copy link
Contributor

@RobertGlobant20 RobertGlobant20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeusongit zeusongit merged commit 3cb3626 into DynamoDS:master May 13, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants