Skip to content

Conversation

@BogdanZavu
Copy link
Contributor

@BogdanZavu BogdanZavu commented Apr 8, 2025

Purpose

Declare existing NodeAutoComplete api obsolete.
We are moving NodeAutoComplete feature to it's own extension.
Existing apis were created mostly due to technical limitations and we don't see a good reason to keep them.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Reviewers

@DynamoDS/synapse

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8606

@QilongTang
Copy link
Contributor

Not sure why the Build DynamoCore.sln / Build DynamoCore linux runtime on linux (pull_request) check would fail, you may want to re-run that check

@BogdanZavu BogdanZavu merged commit daf4773 into DynamoDS:master Apr 9, 2025
25 of 28 checks passed
@BogdanZavu BogdanZavu deleted the DYN-8606 branch April 9, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants