Skip to content

DYN-7245 [CER] Handle crash when fetching hosts from PMClient #15430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QilongTang merged 3 commits into from
Aug 19, 2024
Merged

DYN-7245 [CER] Handle crash when fetching hosts from PMClient #15430

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6db4cf
Update PackageManagerSearchViewModel.cs
zeusongit Aug 15, 2024
e7b5e26
Merge branch 'master' of https://github.com/DynamoDS/Dynamo into DYN-…
zeusongit Aug 15, 2024
40ab2b3
Update PackageManagerSearchViewModel.cs
zeusongit Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerSearchViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -739,11 +739,17 @@ private void Sort(object searchQuery = null)
public List<FilterEntry> InitializeHostFilter()
{
var hostFilter = new List<FilterEntry>();
foreach (var host in PackageManagerClientViewModel.Model.GetKnownHosts())
try
{
hostFilter.Add(new FilterEntry(host, Resources.PackageFilterByHost, Resources.PackageHostDependencyFilterContextItem, this));
foreach (var host in PackageManagerClientViewModel.Model.GetKnownHosts())
{
hostFilter.Add(new FilterEntry(host, Resources.PackageFilterByHost, Resources.PackageHostDependencyFilterContextItem, this));
}
}
catch (Exception ex)
{
PackageManagerClientViewModel.DynamoViewModel.Model.Logger.Log("Could not fetch hosts: " + ex.Message);
}

return hostFilter;
}

Expand Down