Skip to content

DYN-6554 Revert UI Blocking Function calls #14766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QilongTang merged 1 commit into from
Dec 15, 2023
Merged

DYN-6554 Revert UI Blocking Function calls #14766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/DynamoCoreWpf/Views/Menu/PreferencesView.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ public PreferencesView(DynamoView dynamoView)
stylesCustomColors = new ObservableCollection<CustomColorItem>();
UpdateZoomScaleValueLabel(LibraryZoomScalingSlider, lblZoomScalingValue);
UpdateZoomScaleValueLabel(PythonZoomScalingSlider, lblPythonScalingValue);
dynamoView.EnableEnvironment(false);
}

/// <summary>
Expand Down Expand Up @@ -172,7 +171,6 @@ private void CloseButton_Click(object sender, RoutedEventArgs e)

dynViewModel.PreferencesViewModel.TrustedPathsViewModel.PropertyChanged -= TrustedPathsViewModel_PropertyChanged;
dynViewModel.CheckCustomGroupStylesChanges(originalCustomGroupStyles);
(this.Owner as DynamoView).EnableEnvironment(true);

Close();
}
Expand Down
2 changes: 0 additions & 2 deletions src/DynamoCoreWpf/Views/PackageManager/PackageManagerView.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ public PackageManagerView(DynamoView dynamoView, PackageManagerViewModel package
Categories.PackageManager);

this.dynamoView = dynamoView;
dynamoView.EnableEnvironment(false);
}

private void OnRequestShowFileDialog(object sender, PackagePathEventArgs e)
Expand Down Expand Up @@ -131,7 +130,6 @@ private void PackageManagerPanel_MouseDown(object sender, MouseButtonEventArgs e
private void CloseButton_Click(object sender, RoutedEventArgs e)
{
Analytics.TrackEvent(Actions.Close, Categories.PackageManager);
(this.Owner as DynamoView).EnableEnvironment(true);

Close();
}
Expand Down