Skip to content

DYN-6158 Dynamo crashes upon removing item for Package publish list #14314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QilongTang merged 1 commit into from
Aug 25, 2023
Merged

DYN-6158 Dynamo crashes upon removing item for Package publish list #14314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/DynamoCoreWpf/ViewModels/PackageManager/PublishPackageViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1359,7 +1359,7 @@ private void RemoveItem(object parameter)
if (!(parameter is PackageItemRootViewModel packageItemRootViewModel)) return;

string fileName = packageItemRootViewModel.FileInfo == null ? packageItemRootViewModel.Name : packageItemRootViewModel.FileInfo.FullName;
string fileType = packageItemRootViewModel.DependencyType.ToString();
DependencyType fileType = packageItemRootViewModel.DependencyType;

if (fileName.ToLower().EndsWith(".dll") || fileType.Equals(DependencyType.Assembly))
{
Expand All @@ -1379,7 +1379,6 @@ private void RemoveItem(object parameter)

RefreshPackageContents();
return;

}

private bool CanShowAddFileDialogAndAdd()
Expand Down