Skip to content

Conversation

@Amoursol
Copy link
Contributor

@Amoursol Amoursol commented Jun 24, 2022

Purpose

As per https://twitter.com/RyanEJ/status/1540336879492546561, Ryan Johnson noted that he got confused around the wording of "Copy" in the existing way of copying contents to clipboard, assuming it mean copy the node.

This update will make it clear that the command referenced is copying the contents, and not the node.

CopyNodeContents

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Update text on Copy node contents from "Copy" to "Copy Contents".

Reviewers

@DynamoDS/autodesk

FYIs

@QilongTang

@Amoursol Amoursol requested a review from Jingyi-Wen June 25, 2022 17:45
@Jingyi-Wen
Copy link

Great idea, looks good to me! @Amoursol

@QilongTang QilongTang added this to the 2.16.0 milestone Jun 27, 2022
@QilongTang QilongTang merged commit 66f6f70 into master Jun 27, 2022
@QilongTang QilongTang deleted the UpdateCopyToClipboardText branch June 27, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants