Dyn 3578 enable visual settings #11657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added a new workflow (issue_type_predicte.yaml) that is using the ML.NET model for predicting the issue type (source repo), so If a new issue is created in the Dynamo repo this workflow will run and will predict if is a Wishlist issue or not. If is a Wishlist issue it will be labeled as "Wishlist" and then another workflow will move the issue to the DynamoWishlist repo. If the issue is incomplete or is not valid the label "NotMLEvaluated" will be added to the issue. Also I added two scripts more, one will return the issue body in a json string and the other one will clan the issue body removing sections not used like "Dynamo Version" or "Stack Trace"
When testing the issue predicter workflow the issues labeled as Wishlist were not moved to the DynamoWishlist repo due that the "Move Issue by labels" workflow failed. There was a problem with the PAT used to label the issue, I was using the wrong one (no triggers actions).
Enabling the Geometry Scaling section part 1
I added the functionality for re-loading the ScaleValue in the Geometry Scaling section when the Preferences window is re-opened. Also I set-up the binding functionality for the Render Precision section, so the precision will be reflected in the 3d Figure.
I removed some code that won't be used due that the ChangelScaleFactorPrompt window was deleted (now instead of the window we have 4 radio buttons in the Preferences -> Visual Settings -> Geometry Scaling section). Also I deleted some events/commands used when the ScaleFactor changes due that the event won't be used.
This functionality was additional and I think is not needed since is not forcing to re-run the Graph for updating the Render Precision, so it's been deleted.
Contributor
Author
|
This is GIF for showing how the Geometry Scaling and Render Precision Functionality are working. |
9 tasks
QilongTang
reviewed
May 4, 2021
| } | ||
|
|
||
| public event EventHandler RequestScaleFactorDialog; | ||
| public virtual void OnRequestScaleFactorDialog(object sender, EventArgs e) |
Contributor
There was a problem hiding this comment.
Since this is partial class of DynamoViewModel. Let's obsolete instead of fully removal
Contributor
Author
There was a problem hiding this comment.
@QilongTang I re-added the events and obsolete them in the commit: 10e7dfb
QilongTang
approved these changes
May 4, 2021
Contributor
|
@RobertGlobant20 Please address the conflicts and I will make a final review |
Fixing issue that was producing when merging the updated master branch into my feature branch.
Based on Aaron comments instead of removing the event and the method I added the Obsolete decorator.
Contributor
|
Hi @RobertGlobant20 There is a regression |
Contributor
Author
@QilongTang now the DynamoSelfServe job is passing, I just updated the master branch and merged into my feature branch (I think the issue was related to other changes done after this pull request). Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In this pull request I'm enabling the functionality for Geometry Scaling and Render Precision in the Preferences -> Visual Settings tab (Both changes take effect immediately after update).
Also I removed the code related to the old Geometry Scaling functionality (ChangeScaleFactorPrompt) and all the events/commands associated with it.
Related to the UIAutomation tests, there is just only one test that is checking all the entries from the settings menu against some entries in a json file, so even if I implement the functionality for validate the "Geometry Scaling" and "Render Precision" the test will be failing, then we are trying to figure out what to implement for this case.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
FYIs
@Astul-Betizagasti