Skip to content

Conversation

@aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Apr 19, 2021

Purpose

Add documentation for exceptions thrown by UpdateModelValue API
Related to: https://autodesk.slack.com/archives/CL597NGH0/p1618503660006300

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

FYIs

@jhauswirth

Add documentation for exceptions thrown by `UpdateModelValue` API
@mjkkirschner
Copy link
Member

@aparajit-pratap can we add tests enforcing this so the docs don't go out of date without us knowing?

@mjkkirschner
Copy link
Member

LGTM

@aparajit-pratap aparajit-pratap merged commit 103493f into master Apr 19, 2021
@aparajit-pratap aparajit-pratap deleted the aparajit-pratap-patch-2 branch April 19, 2021 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants