Fix for timestamp round-off issue in convert_gps_time #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 18, 2018 21:20
There are round-off errors in the pandas to_timedelta function. This interim fix until, which will remain until the issue gets addressed in the pandas code base, rounds datetimes to the nearest 1000 ns. This only works for times up to a precision of about 10 us.
bradyzp
approved these changes
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying issue exposed in Issue #85 is due to a bug in a low-level function in the pandas library that converts timestamps of any unit into integers in nanoseconds. The fix in this PR should be considered temporary until the associated issue in pandas is fixed.
By passing a timestamp in nanoseconds to the pandas
to_timedeltafunction, rather than a timestamp in seconds, the problematic code path in the pandas library is avoided.Unit tests for the
datetime_to_sowfunction were also included in this PR to catch this issue in the future.Closes Issue #85