Feature/#36 select lines #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaned up old unused code, refactored some methods e.g. plot2 -> plot_series, some small adjustments to Container class. ENH: Added logic to remove FlightLines when new gravity data is imported.
Channels (for Gravity data) can be selected by dragging and dropping them beneath the respective plot titles in the Channel list. TODO: Implement ability to remove channels from the plot. TODO: Add context menu allowing user to clear all channels from specified plot. TODO: Replot channels based on the state saved in the Flight objects upon load, instead of the default (if there is saved state).
Updates to plotter and flight classes to facilitate addition/removal and update of data channels in future via graphical interface. Flight now stores plot state - that is, which of its available data channels are plotted on which axes, to be restored on project load.
Ability to add/remove data channels to and from different plots in workspace. TODO: Performance optimization/fix for data loading in the Flight class. TODO: Enable adding of calculated data series i.e. Eotvos
ENH: Optimized project.py::Flight::get_channel_data function to cache DataFrame on first load, to reduce disk IO operations. FIX: Issue when moving a channel from one plot to another, this now works correctly. FIX: Bug in plotter code when all channels are removed from all plots, as the DateFormatter is unable to handle this situation. FIX: Line Selection removal in Project Tree, rewrote most of the ProjectModel::remove_child code to properly handle removal of items from the model.
cbertinato
approved these changes
Nov 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge in updates allowing manual channel selection for plotting to develop.