Always handle Decimal objects in JSON #56
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
✅ LGTM - This is a great Fix! Thank you, @robotadam! Small merge conflict in requirements.txt. Once that's resolved, I'll do the following -
Thanks for both identifying the issue AND providing the solution @robotadam! 🙏 |
Contributor
Author
|
I merged from main & |
ShreyaThapa
previously approved these changes
Sep 15, 2025
Contributor
ShreyaThapa
left a comment
ShreyaThapa
left a comment
There was a problem hiding this comment.
Thanks @robotadam! Approved! 🎉
robotadam
dismissed
ShreyaThapa’s stale review
The merge-base changed after approval.
ShreyaThapa
previously approved these changes
Sep 15, 2025
spencerhunter
previously approved these changes
Sep 15, 2025
robotadam
dismissed stale reviews from spencerhunter and ShreyaThapa
The merge-base changed after approval.
Contributor
|
Hey @robotadam, mind closing and re-opening the PR? Our approvals aren't working and it appears this is the issue - https://github.com/orgs/community/discussions/58535 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes implicit use of
simplejsonby using standard PythonJSONEncoderclass.Fixes #55 . Right now it includes the testing changes from #54 so that I could include a new test. When that is merged separately this can be evaluated just for
token.pyandtest_token.py.