You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Quote exclusion/blocklist mechanism for unverifiable bundled content #219
Quote exclusion/blocklist mechanism for unverifiable bundled content
Body
While doing a full manual title-consistency review across the bundled quote sources (#181/#217), one quote could not be verified against any indexed source: 76edb02c-3b5b-9249-929c-ef24ff15d0e7 in NikhilNamal17_popular-movie-quotes.json — "Sometimes, informations is more dangerous than weapons", attributed to "Naruto Shippuden" (2007, type movie). A web search found no matching quote from that source. (A separate, genuinely different quote from the same review — 68c2fcd0-..., a Madara Uchiha line, type anime — was confirmed as a real line from the TV series; the two are not duplicates of each other, just coincidentally similar titles.)
This isn't a title/source-spelling problem #181's rule/alias mechanisms can fix — it's a question of whether a specific quote's content should be imported at all. No mechanism currently exists in this codebase to exclude a specific quote (by id or content) from a bundled source file during import; rules and aliases only ever correct fields on quotes that do get imported.
Scope for a future issue:
Design a blocklist/exclusion mechanism — likely a per-source file (mirroring ruleFile/sourceAliasFile's manifest-reference pattern) listing quote ids to skip entirely during import, with a documented reason per entry.
Decide whether this belongs in Quotinator.Data.Import (mechanism) or is purely a manifest/file-level concern.
Apply it (or a manual removal) to the flagged Naruto Shippuden quote above once decided.
Not designed or scoped yet. See docs/milestones/data-import-sources/181-minimal-conflict-resolution-rule-file-plan.md for the full context of the review this came out of.
Activity
docs [#374][#375]: separate "nothing pending" from "data is correct"
fix [#374][#219]: exclude the Shawshank Redemption duplicate via a ne…
fix [#374][#219]: stop a Stale conflict from doubling on every reseed…