Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg 6.0 support and new baseline dependency #15

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

niamu
Copy link
Contributor

@niamu niamu commented Aug 14, 2023

ffmpeg 6.0 renames hls_ts_options to hls_segment_options

This change is not backwards compatible with older versions of ffmpeg so I understand if this isn't something we're ready to adopt yet.

Assuming this is accepted, Dusk-Labs/dim@f67994d changes to.github/workflows/Dockerfile.ci will need to be reverted.

This will also properly close:

@mental32
Copy link
Collaborator

mental32 commented Nov 7, 2023

Can we put this behind a feature flag for now? We should support this just not sure how to get the appropriate changes to Dim's releases done for now.

@a22sc
Copy link

a22sc commented Nov 21, 2023

you could check the available ffmpeg version while staring dim

@martadinata666
Copy link

Fast bandaid is we can use jellyfin-ffmpeg that already a pretty comprehensive release, https://github.com/jellyfin/jellyfin-ffmpeg/releases/tag/v6.0-8. Further, we can focus on the application, rather than be stuck at old ffmpeg, which may not be desirable. In-house build is good but time is our enemy.

@vgarleanu vgarleanu merged commit 878f07e into Dusk-Labs:master Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants