-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONTENT/FEATURE: Missions & Dialogs Overhaul + Los Gerudos Missions Set Progress #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OcelotWalrus
added
enhancement
New feature or request
help wanted
Extra attention is needed
content
Adds data to the game vanilla stuff.
big
This is a big PR/issue
labels
Apr 21, 2024
…lion/Bane-Of-Wargs into patch-and-mission-set
OcelotWalrus
added
documentation
Improvements or additions to documentation
mechanics
Things dealing with the mechanics & code of how the game works
submodule updates
A PR that updates the submodules of the repository
huge
This is a humongous PR/issue
and removed
big
This is a big PR/issue
labels
Apr 22, 2024
Hey @lumbar527! Would you mind giving this PR a small review? Thanks. |
lumbar527
approved these changes
Apr 23, 2024
Co-authored-by: lumbar527 <125756761+lumbar527@users.noreply.github.com>
Co-authored-by: lumbar527 <125756761+lumbar527@users.noreply.github.com>
Co-authored-by: lumbar527 <125756761+lumbar527@users.noreply.github.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
content
Adds data to the game vanilla stuff.
documentation
Improvements or additions to documentation
enhancement
New feature or request
help wanted
Extra attention is needed
huge
This is a humongous PR/issue
mechanics
Things dealing with the mechanics & code of how the game works
submodule updates
A PR that updates the submodules of the repository
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTENT (data addon)/BALANCE/FEATURE/BUGFIX
Summary
This PR first expands the condition statements that can be found in missions and dialogs, by adding three new possibilities:
has items
,random
,has missions active
andhas missions offered
, which expands the capabilities of missions and their dialogs. In addition to that, dialog conversations were given 5 new commands:accept()
,defer()
,decline()
,die()
,display-scene(<name at imgs directory>)
. And finally, missions were given a new trigger:on accept
.This PR also fixes many encountered bugs during its developing; and finally, it expands the Los Gerudos missions set by adding 1 new mission, 1 new character/npc, 2 new map zone and some more back lore to the game! The PR also brings visual changes to the game: from now on, every number that's being printed to the console using the
cout
method, will be formatted to have thousands separators.In plus of the addition of new features to the missions and dialogs, this PR introduces a new data type: the
event
:Event are similar to dialogs, only they don't display any conversation, but they can be triggered using complex attributes to determine a map point. The wiki page can be found here.
Usage examples
I think the mission and dialog overhauls are pretty straightforward, but ask anything that comes to your mind!
Testing Done
Tested pretty much every case scenario.
Testing Method
To test the new mission possibilities, download the BOW-Progression mod and create you own simple missions and dialogs to test it, using the BOW data syntax.
In order to test the new mission, you'll need to load the game data of this PR into your game data folder, with the schemas updated. Then go to the mission offering coordinates(-39, 10) and refresh the game until the offer dialog displays.
Performance Impact
N/A
Check-List
event
data type