Add state field to workflow, allowing deprecated workflows to be hidden #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also changes case on workflow types for consistency
…views - ExcludeDeprecatedWorkflowsMixin applies this behavior to non-admin workflow/workflow-version List APIs - Requires the workflow state field to be in the filter fields - Applies an .exclude() to the QuerySet if the request does not otherwise filter on the field
johnbradley
reviewed
Apr 18, 2019
data/api.py
Outdated
| raise(BespinAPIException(500, 'Cannot use ExcludeDeprecatedWorkflowsMixin without setting ' | ||
| 'state_filter_field to one of the filter_fields: {}' | ||
| .format(self.state_filter_field))) | ||
| queryset = self.queryset |
There was a problem hiding this comment.
Is there a reason we are using self.queryset instead of calling super...get_queryset()?
- Makes mixin less fragile and more flexible - Changes check to None, since empty querysets are falsy
- generics.py will raise if this is not set, behavior in mixin was redundant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stateto workflow with two choices: Active (default) and DeprecatedIn summary - setting a workflow's state to Deprecated will cause it to be hidden from bespin-ui and bespin-cli listings, but still allow the workflow to be accessed by direct URL.