Backport "Do not escape '+' character in x5c of jwks" to 7.1.x#2354
Closed
damianh wants to merge 1 commit intoreleases/is/7.1.xfrom
Closed
Backport "Do not escape '+' character in x5c of jwks" to 7.1.x#2354damianh wants to merge 1 commit intoreleases/is/7.1.xfrom
damianh wants to merge 1 commit intoreleases/is/7.1.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
+character from being escaped as\u002Bin the x5c (certificate chain) property of the JWKS endpoint responseToUnescapedString()method toObjectSerializerusingJavaScriptEncoder.UnsafeRelaxedJsonEscapingCherry-pick Approach
Manual application - cherry-pick failed due to different file paths (
src/IdentityServer/...vsidentity-server/src/IdentityServer/...in 7.4.x). Changes were manually applied to the correct paths and adjusted for FluentAssertions syntax (.Should().NotContain()instead of Shouldly's.ShouldNotContain()).