fix: make ServerSideSessionCleanupHost.StopAsync idempotent#2345
Merged
damianh merged 2 commits intoreleases/is/7.4.xfrom Feb 9, 2026
Merged
fix: make ServerSideSessionCleanupHost.StopAsync idempotent#2345damianh merged 2 commits intoreleases/is/7.4.xfrom
damianh merged 2 commits intoreleases/is/7.4.xfrom
Conversation
Refactor ServerSideSessionCleanupHost to inherit from BackgroundService instead of directly implementing IHostedService. This fixes an issue where StopAsync throws when called multiple times without a corresponding StartAsync call, which occurs in WebApplicationFactory testing scenarios. Fixes: DuendeSoftware/issues#1196
Use while (!stoppingToken.IsCancellationRequested) instead of while (true) with manual cancellation checks, removing redundant code.
damianh
force-pushed
the
dh/ServerSideSessionCleanupHost
branch
from
4427176 to
ab200f2
Compare
bhazen
approved these changes
Feb 8, 2026
damianh
added a commit
that referenced
this pull request
Feb 9, 2026
…nupHost-main fix: make ServerSideSessionCleanupHost.StopAsync idempotent (cherry-pick #2345 to main)
This was referenced Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ServerSideSessionCleanupHostto inherit fromBackgroundServiceinstead of directly implementingIHostedServiceStopAsyncidempotent (safe to call multiple times without throwing)WebApplicationFactory<>testing scenarios where hosted services may be stopped multiple timesChanges
CancellationTokenSourcemanagement withBackgroundService's built-in cancellation handlingwhile (true)towhile (!stoppingToken.IsCancellationRequested)References