Fix incorrect CSP hash constants in check session endpoint#2283
Merged
maartenba merged 2 commits intoreleases/is/7.4.xfrom Dec 3, 2025
Merged
Fix incorrect CSP hash constants in check session endpoint#2283maartenba merged 2 commits intoreleases/is/7.4.xfrom
maartenba merged 2 commits intoreleases/is/7.4.xfrom
Conversation
maartenba
added
area/products/is
Member
|
@maartenba Change the constant. Thanks to you, we have tests now that catch potential future checksession scripts edits / reformats. If that happens again then we need to change the constant again. |
damianh
approved these changes
Dec 3, 2025
maartenba
changed the title
josephdecock
approved these changes
Dec 3, 2025
josephdecock
pushed a commit
that referenced
this pull request
Dec 3, 2025
Add tests for wrong CSP hash constants
This was referenced Dec 3, 2025
Closed
This was referenced Dec 15, 2025
This was referenced Jan 5, 2026
This was referenced Jan 19, 2026
This was referenced Jan 27, 2026
This was referenced Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue does this PR address?
https://github.com/orgs/DuendeSoftware/discussions/425
https://demo.duendesoftware.com/connect/checksession shows a CSP error in Chrome/Safari/Firefox.
The CSP includes a hash for the inline script that comes from https://github.com/DuendeSoftware/products/blob/main/identity-server/src/IdentityServer/Endpoints/Results/CheckSessionResult.cs#L54
The hash is stored in a constant at https://github.com/DuendeSoftware/products/blob/main/identity-server/src/IdentityServer/IdentityServerConstants.cs#L238
The hash in code:
fa5rxHhZ799izGRP38+h4ud5QXNT0SFaFlh4eqDumBI=The expected hash:
4Hj97GNFvt0k8A6DbSr2hoRb/RJmCCakAgE+4zuVeHs=Will need advise on changing the constant vs. reverting whitespace change in
CheckSessionResult.cs