Reworked supported algorithm options#2026
Merged
josephdecock merged 9 commits intomainfrom May 22, 2025
Merged
Conversation
Member
josephdecock
commented
May 22, 2025
josephdecock
commented
- Removed AllowedJwtAlgorithms
- Added SupportedClientAssertionSigningAlgorithms, which controls allowed algs for private_key_jwt
- Added SupportedRequestObjectSigningAlgorithms, which controls allowed algs for JAR
- No alg validation is now done in TokenValidator, instead we rely on the fact that we are validating tokens signed by IdentityServer, and that its signing keys (and their algorithms) are configurable.
bhazen
reviewed
May 22, 2025
identity-server/src/IdentityServer/ResponseHandling/Default/DiscoveryResponseGenerator.cs
Outdated
Show resolved
Hide resolved
josephdecock
force-pushed
the
jmdc/disco-token-algs
branch
from
4cdb287 to
44c3c04
Compare
bhazen
approved these changes
May 22, 2025
Test that the token_endpoint_auth_signing_alg_values_supported are only included if private_key_jwt is enabled.
The discovery document now includes TokenEndpointAuthSigningAlgorithmsSupported only if private_key_jwt is a supported authentication method.
Added a new test to verify request object signing algorithms in the discovery document match the configured AllowedJwtAlgorithms.
- SupportedClientAssertionSigningAlgorithms controls allowed algs for private_key_jwt - SupportedRequestObjectSigningAlgorithms controls allowed algs for JAR - AllowedJwtAlgorithms no longer applies to TokenValidator, instead we rely on the fact that we are validating tokens signed by IdentityServer, and that its signing keys (and their algorithms) are configurable.
If the appropriate supported algorithm option for DPoP, private_key_jwt, or JAR are set to null or empty, we omit that from discovery. This is non-standard behavior that we advise against in the xmldoc, but it is consistent with historical behavior of IdentityServer.
josephdecock
force-pushed
the
jmdc/disco-token-algs
branch
from
44c3c04 to
ef5e2a7
Compare
This was referenced Sep 15, 2025
This was referenced Sep 29, 2025
This was referenced Sep 29, 2025
This was referenced Oct 13, 2025
This was referenced Dec 1, 2025
Closed
Closed
Closed
This was referenced Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.