Options of Allowed Signing Algorithms JWTs and DPoP Proof Tokens#2006
Options of Allowed Signing Algorithms JWTs and DPoP Proof Tokens#2006
Conversation
josephdecock
left a comment
There was a problem hiding this comment.
Please add tests for the dpop proof case, and consider adding tests for the discovery response as well (I think there are existing integration tests so it should be straightfoward).
...server/src/IdentityServer/Configuration/DependencyInjection/Options/IdentityServerOptions.cs
Outdated
Show resolved
Hide resolved
@josephdecock There's an existing test in DPoPProofValidationTests with a |
…ection/Options/IdentityServerOptions.cs Co-authored-by: Joe DeCock <josephdecock@gmail.com>
Oh, nice. I guess we could make use of the new option in that test though? That would cover what we will do in the FAPI 2.0 case. |
…to explicitly use setting for controlling allowed algorithms
@josephdecock tests have been added/updated. |
What issue does this PR address?
Adds new options for allowed signing algorithms for JWTs and DPoP proof tokens for scenarios when the supported algorithms need to be restricted such as the FAPI 2.0 Profile.
Important: Any code or remarks in your Pull Request are under the following terms:
If You provide us with any comments, bug reports, feedback, enhancements, or modifications proposed or suggested by You for the Software, such Feedback is provided on a non-confidential basis (notwithstanding any notice to the contrary You may include in any accompanying communication), and Licensor shall have the right to use such Feedback at its discretion, including, but not limited to the incorporation of such suggested changes into the Software. You hereby grant Licensor a perpetual, irrevocable, transferable, sublicensable, nonexclusive license under all rights necessary to incorporate and use your Feedback for any purpose, including to make and sell any products and services.
(see our license, section 7)