Skip to content

Comments

Options of Allowed Signing Algorithms JWTs and DPoP Proof Tokens#2006

Merged
bhazen merged 5 commits intomainfrom
beh/jwt-validation-algorithm-option
May 9, 2025
Merged

Options of Allowed Signing Algorithms JWTs and DPoP Proof Tokens#2006
bhazen merged 5 commits intomainfrom
beh/jwt-validation-algorithm-option

Conversation

@bhazen
Copy link
Contributor

@bhazen bhazen commented May 9, 2025

What issue does this PR address?
Adds new options for allowed signing algorithms for JWTs and DPoP proof tokens for scenarios when the supported algorithms need to be restricted such as the FAPI 2.0 Profile.

Important: Any code or remarks in your Pull Request are under the following terms:

If You provide us with any comments, bug reports, feedback, enhancements, or modifications proposed or suggested by You for the Software, such Feedback is provided on a non-confidential basis (notwithstanding any notice to the contrary You may include in any accompanying communication), and Licensor shall have the right to use such Feedback at its discretion, including, but not limited to the incorporation of such suggested changes into the Software. You hereby grant Licensor a perpetual, irrevocable, transferable, sublicensable, nonexclusive license under all rights necessary to incorporate and use your Feedback for any purpose, including to make and sell any products and services.

(see our license, section 7)

@bhazen bhazen self-assigned this May 9, 2025
@bhazen bhazen requested a review from josephdecock as a code owner May 9, 2025 15:38
@bhazen bhazen added the area/products/is IdentityServer label May 9, 2025
Copy link
Member

@josephdecock josephdecock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for the dpop proof case, and consider adding tests for the discovery response as well (I think there are existing integration tests so it should be straightfoward).

@bhazen
Copy link
Contributor Author

bhazen commented May 9, 2025

Please add tests for the dpop proof case, and consider adding tests for the discovery response as well (I think there are existing integration tests so it should be straightfoward).

@josephdecock There's an existing test in DPoPProofValidationTests with a invalid_alg_should_fail_validation test which covers this behavior. Were there other scenarios you wanted covered?

…ection/Options/IdentityServerOptions.cs

Co-authored-by: Joe DeCock <josephdecock@gmail.com>
@josephdecock
Copy link
Member

Please add tests for the dpop proof case, and consider adding tests for the discovery response as well (I think there are existing integration tests so it should be straightfoward).

@josephdecock There's an existing test in DPoPProofValidationTests with a invalid_alg_should_fail_validation test which covers this behavior. Were there other scenarios you wanted covered?

Oh, nice. I guess we could make use of the new option in that test though? That would cover what we will do in the FAPI 2.0 case.

@bhazen
Copy link
Contributor Author

bhazen commented May 9, 2025

Please add tests for the dpop proof case, and consider adding tests for the discovery response as well (I think there are existing integration tests so it should be straightfoward).

@josephdecock There's an existing test in DPoPProofValidationTests with a invalid_alg_should_fail_validation test which covers this behavior. Were there other scenarios you wanted covered?

Oh, nice. I guess we could make use of the new option in that test though? That would cover what we will do in the FAPI 2.0 case.

@josephdecock tests have been added/updated.

@bhazen bhazen merged commit c391b92 into main May 9, 2025
17 checks passed
@bhazen bhazen deleted the beh/jwt-validation-algorithm-option branch May 9, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/products/is IdentityServer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants