Ensure WWW-Authenticate uses a single HTTP header #1998
Merged
josephdecock merged 4 commits intoreleases/is/7.2.xfrom May 7, 2025
Merged
Ensure WWW-Authenticate uses a single HTTP header #1998josephdecock merged 4 commits intoreleases/is/7.2.xfrom
josephdecock merged 4 commits intoreleases/is/7.2.xfrom
Conversation
josephdecock
changed the title
josephdecock
force-pushed
the
ka-fix-WWWAuthenticate
branch
2 times, most recently
from
b63dc09 to
8f1f4c8
Compare
Introduce tests for ProtectedResourceErrorResult to ensure WWW-Authenticate header formatting is correct. Refactor header construction values into a single string.
josephdecock
force-pushed
the
ka-fix-WWWAuthenticate
branch
from
8f1f4c8 to
a0e9118
Compare
This is only adding the dependency, not updating all the tests. This gives us an easy way to write tests that will merge cleanly into main.
josephdecock
force-pushed
the
ka-fix-WWWAuthenticate
branch
from
a0e9118 to
ddd59d5
Compare
Member
|
I've updated the tests to use Shoudly so that this fix will merge more easily into main. I've also made some minor tooling fixes to the release branches. They now all increment minver patch versions, and this branch was rebased on to that change. I also ran into a vscode settings file not getting ignored, so I added that to gitignore. |
bhazen
approved these changes
May 7, 2025
This was referenced Sep 15, 2025
This was referenced Sep 29, 2025
This was referenced Sep 29, 2025
This was referenced Oct 13, 2025
This was referenced Dec 1, 2025
Closed
Closed
Closed
This was referenced Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce tests for ProtectedResourceErrorResult to ensure WWW-Authenticate header formatting is correct. Refactor header construction values into a single string.