Harden default logging filters for PAR and Authorize endpoints (7.0)#1976
Merged
josephdecock merged 3 commits intoreleases/is/7.0.xfrom Apr 25, 2025
Merged
Harden default logging filters for PAR and Authorize endpoints (7.0)#1976josephdecock merged 3 commits intoreleases/is/7.0.xfrom
josephdecock merged 3 commits intoreleases/is/7.0.xfrom
Conversation
We've removed this config file from later branches, and backporting that change makes local dev simpler.
The mock logger was introduced in 7.1 and allows us to write tests that make assertions about what was logged. We need this in 7.0 to test the sensitive values filter.
PAR requests sometimes are handled by the same code path as authorize requests, so both endpoint's default sensitive values filter should be the same.
josephdecock
added
area/products/is
josephdecock
changed the title
bhazen
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PAR requests sometimes are handled by the same code path as authorize requests, so both endpoint's default
sensitive values filter should be the same.