Skip to content

Comments

Implement RFC 9701 to Return JWT Response from Introspection Endpoint#1937

Merged
josephdecock merged 1 commit intomainfrom
beh/jwt-introspection-response
Apr 16, 2025
Merged

Implement RFC 9701 to Return JWT Response from Introspection Endpoint#1937
josephdecock merged 1 commit intomainfrom
beh/jwt-introspection-response

Conversation

@bhazen
Copy link
Contributor

@bhazen bhazen commented Apr 2, 2025

What issue does this PR address?
Updates the token introspection endpoint to support the behavior for returning the response as a JWT as defined in RFC 9701

Important: Any code or remarks in your Pull Request are under the following terms:

If You provide us with any comments, bug reports, feedback, enhancements, or modifications proposed or suggested by You for the Software, such Feedback is provided on a non-confidential basis (notwithstanding any notice to the contrary You may include in any accompanying communication), and Licensor shall have the right to use such Feedback at its discretion, including, but not limited to the incorporation of such suggested changes into the Software. You hereby grant Licensor a perpetual, irrevocable, transferable, sublicensable, nonexclusive license under all rights necessary to incorporate and use your Feedback for any purpose, including to make and sell any products and services.

(see our license, section 7)

@bhazen bhazen added the area/products/is IdentityServer label Apr 2, 2025
@bhazen bhazen self-assigned this Apr 2, 2025
@bhazen bhazen force-pushed the beh/jwt-introspection-response branch 3 times, most recently from 0f7aafe to 1a2ace6 Compare April 11, 2025 18:15
@bhazen bhazen marked this pull request as ready for review April 11, 2025 18:24
@bhazen bhazen requested a review from josephdecock as a code owner April 11, 2025 18:24
Copy link
Member

@josephdecock josephdecock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! My only concern is that we should verify that an access token's claims get serialized correctly if they are complex or nested values. Can we add a test to prove that that arrays and nested objects work?

@bhazen bhazen force-pushed the beh/jwt-introspection-response branch from 1a2ace6 to e751718 Compare April 16, 2025 13:43
@bhazen
Copy link
Contributor Author

bhazen commented Apr 16, 2025

Looks great! My only concern is that we should verify that an access token's claims get serialized correctly if they are complex or nested values. Can we add a test to prove that that arrays and nested objects work?

@josephdecock I added a couple more tests at the end of the introspection endpoint tests file. Let me know if that is not what you were looking for with this comment.

@bhazen bhazen force-pushed the beh/jwt-introspection-response branch from e751718 to 14da6df Compare April 16, 2025 13:53
@josephdecock josephdecock merged commit cfda4bb into main Apr 16, 2025
17 checks passed
@josephdecock josephdecock deleted the beh/jwt-introspection-response branch April 16, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/products/is IdentityServer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants