Fix incorrect 'for' attribute in userCode inputs#1712
Merged
khalidabuhakmeh merged 2 commits intomainfrom Jan 8, 2025
Merged
Conversation
Replaced the incorrect 'for' attribute with 'id' for the userCode input fields across multiple Index.cshtml files to ensure proper HTML semantics and accessibility. This change aligns the input fields with their respective labels.
khalidabuhakmeh
force-pushed
the
ka-fix-userCode-id
branch
from
a8ca778 to
ba49710
Compare
maartenba
approved these changes
Jan 8, 2025
josephdecock
requested changes
Jan 8, 2025
Member
josephdecock
left a comment
josephdecock
left a comment
There was a problem hiding this comment.
Let's make the same changes in the templates subdirectory.
Replaced the erroneous "for" attribute with the correct "id" attribute in the userCode input fields across multiple Device/Index.cshtml files in the templates directory.
josephdecock
approved these changes
Jan 8, 2025
This was referenced Sep 15, 2025
This was referenced Sep 29, 2025
This was referenced Oct 13, 2025
This was referenced Dec 1, 2025
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the incorrect 'for' attribute with 'id' for the userCode input fields across multiple Index.cshtml files to ensure proper HTML semantics and accessibility. This change aligns the input fields with their respective labels.