Add new license management services#1637
Merged
josephdecock merged 22 commits intomainfrom Dec 11, 2024
Merged
Conversation
josephdecock
force-pushed
the
joe/licensing
branch
from
87fcb3e to
e0fb86d
Compare
josephdecock
commented
Nov 21, 2024
josephdecock
commented
Nov 21, 2024
josephdecock
commented
Nov 21, 2024
josephdecock
force-pushed
the
joe/licensing
branch
from
bd8d75e to
8f58e3f
Compare
josephdecock
force-pushed
the
joe/licensing
branch
2 times, most recently
from
884c130 to
072bfdd
Compare
Some files in license v2 had an autogenerated apache license header, but they are not apache licensed. Yo dawg, I heard you were changing the licensing code, so I changed the license of your license code...
Note that the license files we're checking in issued to the _test company and are already expired
josephdecock
force-pushed
the
joe/licensing
branch
from
3d7c852 to
d685b97
Compare
josephdecock
force-pushed
the
joe/licensing
branch
from
444a2ac to
bb04af5
Compare
josephdecock
force-pushed
the
joe/licensing
branch
from
87c30c6 to
7780b3a
Compare
josephdecock
commented
Dec 4, 2024
- Make services private - Add public LicenseSummary - Show how to use LicenseSummary in main host - Remove license usage hosted service - Track used license features by minimum license level that supports them
josephdecock
force-pushed
the
joe/licensing
branch
from
7780b3a to
670b333
Compare
- Cut warning about license expiration - Simplify usage summary
josephdecock
force-pushed
the
joe/licensing
branch
from
d10789c to
802205b
Compare
josephdecock
requested review from
damianh
and removed request for
brockallen
damianh
reviewed
Dec 10, 2024
damianh
reviewed
Dec 10, 2024
damianh
reviewed
Dec 10, 2024
This is more consistent with the other usage tracking.
We check if the dictionary contains the key first, because it performs better given our workload. Typically these sets will contain a small number of elements, and won't change much over time (e.g., the first time we try to use DPoP, that gets added, and then all subsequent requests with a proof don't need to do anything here). ConcurrentDictionary's ContainsKey method is lock free, while TryAdd always acquires a lock, so in the (by far more common) steady state, the ContainsKey check is much faster.
damianh
approved these changes
Dec 11, 2024
josephdecock
changed the title
josephdecock
changed the title
This was referenced Dec 1, 2025
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.