Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove keyword workspace in mapWorkspacesToMonitors as it doesnt work anyway #91

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

zjeffer
Copy link
Collaborator

@zjeffer zjeffer commented Jun 8, 2024

Closes #37

Two issues with this line:

  • The correct command is `hyprctl keyword workspace ,monitor:<monitor_name>
  • The line doesn't do anything anyway because we're reloading the config afterwards, which removes all workspacerules set by the plugin. This is why we have to use the workaround in writeWorkspaceRules.

@zjeffer zjeffer added the bug Something isn't working label Jun 8, 2024
@zjeffer zjeffer requested a review from Duckonaut June 8, 2024 09:39
@zjeffer zjeffer self-assigned this Jun 8, 2024
@zjeffer zjeffer merged commit 81adb1c into main Jun 14, 2024
2 checks passed
@zjeffer zjeffer deleted the fix/zjeffer/fix-keyword-workspace branch December 19, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad workspace rule command overwrites user defined rules
1 participant