Skip to content

Basic Database Structure#15

Merged
HuseyinSimsek7904 merged 23 commits intomainfrom
db-structure
Apr 22, 2024
Merged

Basic Database Structure#15
HuseyinSimsek7904 merged 23 commits intomainfrom
db-structure

Conversation

@Utkub24
Copy link
Contributor

@Utkub24 Utkub24 commented Mar 23, 2024

  • I have not added anything unrelated of this PR to the PR message (I had to make the joke sry)

Closes #1

I (@HuseyinSimsek7904 not @Utkub24) got bored so I decided to create database services for the project. I did not have 5 PRs that are ready and waiting for review, so you are completely right to say that I should not be bored.

Explanation of the contents of the PR

The PR has two main parts: the makefile and interface/service/controllers for the database. The makefile is updated so that the developer can generate a valid database for experiments and tests. The code changes contain new interfaces and other database management programs for the database entries types: user, raffle and participant. There is also formQuestion interface which is used for storing the information of the form questions that the raffle table contains.

Future plans

Currently we do not have any plans. We should discuss this as soon as possible.

Notes

  • This PR contains breaking changes about the .env file. Please update your it after this PR according to the wiki entry.
  • All of the raffles that the makefile generates have an empty form field.
  • I can not add @Utkub24 as a reviewer as he is the owner of the PR, but I want him to review as well.

@Utkub24 Utkub24 added enhancement New feature or request database Storing data and stuff p1 Most important labels Mar 23, 2024
@Utkub24 Utkub24 self-assigned this Mar 23, 2024
@Utkub24 Utkub24 requested a review from erthium March 23, 2024 01:03
note: please update your .env file as this branch now uses a different set of names for the environment variables. check the wiki entry for more information.
@HuseyinSimsek7904
Copy link
Contributor

Please before continuing your work @Utkub24, refresh your .env file according to the wiki entry. I had to update its variable names so that both the Makefile and the nestJS application could use it without weird name conventions and redefinitions.

@HuseyinSimsek7904
Copy link
Contributor

@Utkub24 Why would you remove the checklist before converting the PR from a draft? Now we have to manually copy-paste them after we are done.

Let's not remove these checklists before the PR is ready.

@HuseyinSimsek7904 HuseyinSimsek7904 self-assigned this Mar 28, 2024
@Utkub24
Copy link
Contributor Author

Utkub24 commented Mar 28, 2024

copy-paste

Is this intentional?

@HuseyinSimsek7904
Copy link
Contributor

copy-paste

Is this intentional?

'course it is.

@HuseyinSimsek7904
Copy link
Contributor

@Utkub24 I need your help writing the description here. I think the PR is ready.

@HuseyinSimsek7904 HuseyinSimsek7904 marked this pull request as ready for review April 2, 2024 11:42
@erthium
Copy link
Member

erthium commented Apr 2, 2024

I checked the files a bit, as for follow-up suggestions, we need to have to routes to be used in the client side that:

  • Checks if a raffle ID is valid or not, if so, checks the senders IP address and determines if they have submitted before, if so, we will send a special respons telling us in the front-end to show the user 'Thanks for submitting!' component.
  • Gets the raffle data/information which needs to be stripped from confidential data, like we may want to exclude author info, any participant relation etc. if there is any

@erthium
Copy link
Member

erthium commented Apr 2, 2024

Will also check the PR very soon, things seem pretty cool though, good job 👍

@erthium
Copy link
Member

erthium commented Apr 2, 2024

Also for follow-up, we do not have routes for registering participants, and creating new raffles

@HuseyinSimsek7904
Copy link
Contributor

Also for follow-up, we do not have routes for registering participants, and creating new raffles

Oh, right. Can you please create an issue for this? Or separate issues?

Copy link
Member

@erthium erthium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!

@HuseyinSimsek7904 HuseyinSimsek7904 merged commit 8957e1d into main Apr 22, 2024
@HuseyinSimsek7904 HuseyinSimsek7904 deleted the db-structure branch April 22, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

database Storing data and stuff enhancement New feature or request p1 Most important

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Database Integration

3 participants