fix: MirrorNetworking#3340 SyncSet/Dictionary callbacks are only call…

…ed once
DruidTin · Jan 5, 2023 · 7b7ad85 · 7b7ad85
1 parent c5aa474
commit 7b7ad85
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 13 deletions.
diff --git a/Assets/Mirror/Core/SyncDictionary.cs b/Assets/Mirror/Core/SyncDictionary.cs
@@ -219,13 +219,9 @@ public override void OnDeserializeDelta(NetworkReader reader)
                         break;
                 }
 
-                if (apply)
-                {
-                    Callback?.Invoke(operation, key, item);
-                }
-                // we just skipped this change
-                else
+                if (!apply)
                 {
+                    // we just skipped this change
                     changesAhead--;
                 }
             }

diff --git a/Assets/Mirror/Core/SyncList.cs b/Assets/Mirror/Core/SyncList.cs
@@ -1,7 +1,6 @@
 using System;
 using System.Collections;
 using System.Collections.Generic;
-using UnityEngine;
 
 namespace Mirror
 {

diff --git a/Assets/Mirror/Core/SyncSet.cs b/Assets/Mirror/Core/SyncSet.cs
@@ -197,13 +197,9 @@ public override void OnDeserializeDelta(NetworkReader reader)
                         break;
                 }
 
-                if (apply)
-                {
-                    Callback?.Invoke(operation, item);
-                }
-                // we just skipped this change
-                else
+                if (!apply)
                 {
+                    // we just skipped this change
                     changesAhead--;
                 }
             }