Skip to content

Dialog/Theme function text standardization #348

@TonyGravagno

Description

@TonyGravagno

I propose standardizing text between the Dialog object and the Theme object, where many Set functions only operate on dialogs created with the "old" option. This ticket is mirrored in the VSCode extension where some text is incorrect or incomplete in similar ways. The net effect of processing these two tickets is that the text will be consistent and correct for both environments.

DsDialog

SetTitleColor
Currently: Changes the color of the dialog title. Only works with "Old" option.
No change. This is the base for others.

These functions defined for Dialog also only work with old dialogs:
SetTitleHeight
SetTitleDividerColor
SetTitleDividerHeight
SetTitleTextSize

DsTheme

Note in the following that functions that only apply to dialogs are noted as such, and functions that only apply to the "old" option are noted consistently with the Dialog text.

SetTitleColor
Currently: Define title colors / Define standard title text color of dialogs.
Replacement: Define standard title text color of dialogs. Only works with "Old" dialog option.

SetTitleHeight
Currently: Define standard height of dialogs
Replacement: Define standard height of dialogs. Only works with "Old" dialog option.

SetTitleDividerColor
Currently: Define title divider colors / app.d.ts says "height"
Replacement: Define standard title divider color of dialogs. Only works with "Old" dialog option.

SetTitleDividerHeight
Currently: Define title divider height
Replacement: Define standard title divider height of dialogs. Only works with "Old" dialog option.

SetTitleTextSize
Currently: Define title text size
Replacement: Define standard title text size of dialogs. Only works with "Old" dialog option.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions