Color Picker, Color Buttons #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Larkinabout
commented
Sep 6, 2022
Larkinabout
commented
- Color Picker: Add Color Picker library for module settings.
- Color Buttons: Add settings to color button background and border.
- Color Picker: Add Color Picker library for module settings. - Color Buttons: Add settings to color button background and border.
- Tidy up errant changes from previous commit.
|
@Drental, I've created this a pull request to check you're happy with the changes before merging into master. It adds a dependency on the Color Picker library module to provide a color picker for the colorable module settings. I've added two more settings: Button Background Color and Button Border Color. |
|
I don't like adding a dependency, but I guess color picker is a rather light one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.