Kernel implementations #5
Conversation
jrg94
left a comment
jrg94
left a comment
There was a problem hiding this comment.
There is a ton of really solid and interesting work here. I feel a bit out of my depth reviewing it, and I'm going to trust your judgment.
|
|
||
| // TODO - fill in body | ||
|
|
||
| if(password==null||truePassword==null) { |
There was a problem hiding this comment.
I don't think there is anything wrong with this, but I wouldn't make createNewRep conditional on whatever the current variables store. The idea should be that createNewRep gives you a fresh representation every time.
I'm wondering if the keystore logic could be in a private method that you call after you initialize your variables. That said, I haven't looked at your code deep enough to really make a solid recommendation.
|
|
||
| // Copy all keys and metadata from source to this | ||
| int sourceSize = localSource.size(); | ||
| for (int i = 0; i < sourceSize; i++) { |
There was a problem hiding this comment.
Usually, transferFrom is an O(1) operation. Is there a way to transfer the rep directly without these loops?
2 participants
No description provided.