[Tests] Add polymarket get_positions #3178
Open
+48
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
1006
to
1009
| async def test_fetch_positions(self): | ||
| # pass if not implemented | ||
| async with self.local_exchange_manager(): | ||
| await self.inner_test_fetch_positions() |
Member
There was a problem hiding this comment.
is it a different type of test compared to the positions tests in AbstractAuthenticatedFutureExchangeTester ? If yes, can we give a more explicit name to this test to avoid confusion with positions-releated tests of the futures exchanges test framework ?
Member
Author
There was a problem hiding this comment.
My bad, I missed that AbstractAuthenticatedFutureExchangeTester exists
Herklos
force-pushed
the
feature/add-polymarket-tests
branch
2 times, most recently
from
57716c4 to
eb6f793
Compare
Signed-off-by: Herklos <herklos@drakkar.software>
Herklos
force-pushed
the
feature/add-polymarket-tests
branch
from
eb6f793 to
561a997
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires Drakkar-Software/OctoBot-Trading#1318