Reduce compiler warnings (-Wall -Wpedantic) #880
Conversation
SuiteSparse 7.8.1: update to GraphBLAS 9.3.1
For SuiteSparse 7.8.2
Bumps [Jimver/cuda-toolkit](https://github.com/jimver/cuda-toolkit) from 0.2.16 to 0.2.18. - [Release notes](https://github.com/jimver/cuda-toolkit/releases) - [Commits](Jimver/cuda-toolkit@v0.2.16...v0.2.18) --- updated-dependencies: - dependency-name: Jimver/cuda-toolkit dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…ependabot/github_actions/Jimver/cuda-toolkit-0.2.18 Bump Jimver/cuda-toolkit from 0.2.16 to 0.2.18
ParU 1.0.0 for SuiteSparse 7.8.3
Extra semicolons are forbidden outside a function. Found by GCC 15 (Wpedantic)
In release builds the asserts are removed and the compiler warns about the unused variables. This can only be done with C++ (and C 23). Found by GCC 15 (Wunused-but-set-variable)
Found by GCC (Wenum-int-mismatch)
Found by Clang 19
|
Looks good. I haven't had time to try these out but will do so when my schedule allows. My organization requires a minor revision to my Contributor Agreement, for all new contributions. Can you sign the new one I just posted? It's here in the dev branch: |
|
Also, I need to revise the PR to go to the dev2 branch, not dev. The two branches are in sync so that shouldn't be a problem. |
| @@ -65,8 +65,8 @@ int runEdgeSeparatorTest(const std::string &inputFile, const double targetSplit) | |||
| int count = 0; | |||
| for (int i = 0; i < result->n; i++) | |||
| { | |||
| bool equals_0 = (result->partition[i] == 0); | |||
| bool equals_1 = (result->partition[i] == 1); | |||
| [[maybe_unused]] bool equals_0 = (result->partition[i] == 0); | |||
There was a problem hiding this comment.
The [[maybe_unused]] attribute was only added to the C++ standard in C++17, but the Mongoose CMake is configured to request C++11
SuiteSparse/Mongoose/CMakeLists.txt
Line 192 in fd8a7d1
So I think this could lead to problems with some compilers if they are stricter with standard conformance.
There was a problem hiding this comment.
Good point -- thanks for the catch!
Mongoose only assumes c++11 so we cannot use that here.
No description provided.