Repository navigation
fix(notifications): images don't show in notifications - #2203
Open
Zensonaton wants to merge 7 commits into
Open
Zensonaton wants to merge 7 commits into
Zensonaton wants to merge 7 commits into
Conversation
Only the largest size was looked up, which is usually not downloaded.
Follows the auto-download settings, the notification is redrawn once the photo is loaded.
They were passed as webp images that can't be decoded.
Revoking it after 20 s broke the image when the notification was redrawn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes images that aren't being downloaded and shown in notifications unless cached. This affects images and stickers.
Screencasts
before.mp4
after.mp4
Google Pixel 11 Pro with Android 17 (stable) used for the screenshots.
Further notes
Footnotes
Tested on Telegram v13.0.2 (7175). ↩
Cache was cleared for stock and fork versions of Telegram before recording. ↩ ↩2
Avatar fix isn't included in this PR. See PR-2195 for details. ↩