Skip to content

feat: Support ESLint for Volar and vue-tsc (WIP) #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat: Support ESLint for Volar and vue-tsc (WIP) #1

wants to merge 11 commits into from

Conversation

johnsoncodehk
Copy link

@johnsoncodehk johnsoncodehk commented Dec 14, 2022 •
edited
Loading

See vuejs/language-tools#2204

  • IDE support (@volar-plugins/eslint)
  • CLI support (vue-tsc-eslint-hook)
  • eslint-plugin-vue rules support

@DrJume
Copy link
Owner

DrJume commented Dec 16, 2022 •
edited
Loading

Thank you for this PR! 😃

I really like the approach, but sadly it does not support eslint-plugin-vue rules.
Even if it is slower, it would be really nice to run the Vue ESLint rules and having TypeScript understand Vue SFCs.

Having the possibity to run the linting / type checking inside CI or in CLI is really important for me.

@johnsoncodehk johnsoncodehk changed the title refactor: vue-eslint-parser -> @volar-plugins/eslint [WIP] refactor: vue-eslint-parser -> @volar-plugins/eslint Dec 17, 2022
@johnsoncodehk johnsoncodehk marked this pull request as draft December 17, 2022 22:43
@johnsoncodehk johnsoncodehk changed the title [WIP] refactor: vue-eslint-parser -> @volar-plugins/eslint feat: Use @volar-plugins/eslint and vue-tsc-eslint-hook Dec 18, 2022
@johnsoncodehk
Copy link
Author

I can't make vue-eslint-parser work with it currently 😵, but vue-tsc and Volar are supported, can you take a try?

@johnsoncodehk johnsoncodehk changed the title feat: Use @volar-plugins/eslint and vue-tsc-eslint-hook feat: Support ESLint for Volar and vue-tsc Dec 18, 2022
@johnsoncodehk johnsoncodehk changed the title feat: Support ESLint for Volar and vue-tsc (WIP) Support ESLint for Volar and vue-tsc (WIP) Dec 18, 2022
@johnsoncodehk johnsoncodehk changed the title (WIP) Support ESLint for Volar and vue-tsc (WIP) feat: Support ESLint for Volar and vue-tsc (WIP) Dec 18, 2022
@johnsoncodehk johnsoncodehk mentioned this pull request Dec 20, 2022
Closed
@johnsoncodehk johnsoncodehk marked this pull request as ready for review December 21, 2022 08:37
@johnsoncodehk johnsoncodehk mentioned this pull request Mar 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnsoncodehk @DrJume